Mercurial Mercurial > beremiz / annotate
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | file | latest | revisions | annotate | diff | comparison | raw | help
doc/about.ru.html
author Andrey Skvortsov <andrej.skvortzov@gmail.com>
Thu, 28 Apr 2016 13:05:57 +0300
changeset 1507 d7f474d10210
parent 1500 007588fb6549
child 1513 b7b8d29e2a2d
permissions -rw-r--r--
fix issue with sometimes wrong return code of ProcessLogger


As a result of wrong return code Beremiz gives folowing traceback:
Traceback (most recent call last):
File "./Beremiz.py", line 850, in OnMenu
getattr(self.CTR, method)()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 925, in _Build
IECGenRes = self._Generate_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 568, in _Generate_SoftPLC
return self._Compile_ST_to_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 661, in _Compile_ST_to_SoftPLC
C_files.remove("POUS.c")
ValueError: list.remove(x): x not in list

The problem is that both threads (for reading stdout and stderr) call self.Proc.poll(),
that updates internal returncode field. This call is done without any locking and the first thread gets correct result,
but other gets 0 as retval. If 0 gets thread, that afterwards calls callback finish, then wrong return code is returned
to the parent. Now only the thread with a callback polls for the return code, other thread just checked local value.

Additionally function spin() waits now until all threads finish reading their pipes, so the results are always correct.
1491
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
     1
 
<!DOCTYPE html>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
     2
 
<HTML lang="ru">
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
     3
 
  <HEAD><meta charset="utf-8" http-equiv="Content-Type" content="text/html; charset=utf-8">
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
     4
 
    <TITLE>О Beremiz</TITLE>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
     5
 
  </HEAD>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
     6
 
  <BODY>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
     7
 
    <CENTER>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
     8
 
      <IMG SRC="../images/splash.png">
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
     9
 
      <BR><BR>
1500
007588fb6549 update Russian about Beremiz dialog window
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents: 1491
diff changeset 
    10
 
      <font size="3">Beremiz - это свободное программное обеспечение для автоматизации.</font>
1491
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    11
 
      <BR><BR>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    12
 
      <a href="http://www.beremiz.org/">http://www.beremiz.org/</a>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    13
 
      <BR><BR>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    14
 
      <TABLE border="0">
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    15
 
        <TR>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    16
 
          <TD align="right" valign="top">
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    17
 
            Спонсор разработки:
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    18
 
          </TD>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    19
 
          <TD align="left" valign="top">
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    20
 
            Университет Порту<BR>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    21
 
            <a href="http://www.fe.up.pt/si/web_page.inicial">http://www.fe.up.pt/si/web_page.inicial</a>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    22
 
          </TD>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    23
 
        </TR>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    24
 
      </TABLE>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    25
 
    </CENTER>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    26
 
  </BODY>
f3c26ebce488 add translation of "about" window into Russian
Andrey Skvortsov <andrej.skvortzov@gmail.com>
parents:
diff changeset 
    27
 
</HTML>
beremiz